Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Image to comp or shader: fix applying colorspace #73

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Nov 9, 2024

Changelog Description

Fix setting of colorspace

Additional review information

Fixes #72

Testing notes:

  1. Load image to compositor and load image to shader should correctly set colorspace.

@BigRoy BigRoy added type: bug Something isn't working community Issues and PRs coming from the community members labels Nov 9, 2024
@BigRoy BigRoy requested a review from LiborBatek November 9, 2024 15:45
@BigRoy BigRoy self-assigned this Nov 9, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesnt work for me...

did try to load PNG but its set to ACEScc instead of sRGB
image

sry dont know how to provide you some log as there is not any.
could I help you somehow with more info to debug?!

@LiborBatek
Copy link
Member

however its fair to note that for EXR it reads and sets colorspace well (aka correct ACEScg)

image

@BigRoy
Copy link
Contributor Author

BigRoy commented Nov 11, 2024

@LiborBatek can you confirm the loaded PNG representation has colorspace data stored on the representation?

Also, we should really start adding the "colorspace" as data into the loader UI so this is much easier to visualize for anyone. Basically implement something similar to this: ynput/OpenPype#5459 -- created this issue: ynput/ayon-core#1006

@BigRoy BigRoy requested a review from LiborBatek November 11, 2024 10:02
@LiborBatek
Copy link
Member

as far as I can tell (also by inspecting product / version details) there is no colorspace written for my image (been published from ayon PS integration)

Screenshot 2024-11-12 145935

@BigRoy
Copy link
Contributor Author

BigRoy commented Nov 12, 2024

as far as I can tell (also by inspecting product / version details) there is no colorspace written for my image (been published from ayon PS integration)

  1. A version does not have a colorspace - but representations have it. As far as I know, there isn't a way to currently visualize it anywhere. Hence the issue here: Show representation colorspaces in the Loader ayon-core#1006

  2. Can you publish an image through Tray Publisher, explicitly set some colorspace override there for the image (something that's not a default colorspace so we're sure it's being set inside Blender), publish it. And load that image into Blender?

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once using image product with colorspace added (via tray publisher) it seem working correctly and my color space on file node matches the image one...

image

@BigRoy BigRoy merged commit f1517f2 into ynput:develop Nov 13, 2024
1 check passed
@BigRoy BigRoy deleted the bugfix/load_comp_image_colorspace branch November 13, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

colorspace is never applied by load_image_compositor and load_image_shader
2 participants